Rando V3 - Small UI Cleanup #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify Combobox and Slider Options to clamp directly to options.size() - 1 instead of just decrementing if current value is higher than max.
Pepe20129
reviewed
Sep 27, 2024
Pepe20129
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Looks good.
I've just though that maybe we should eventually have a setting to change the checkbox to have an X when disabled again but that's something for the future when more "UI settings" are implemented (like accent color, configurable padding/text size, etc.).
|
Yeah, this was more for consistency, as normal checkboxes being off are blank, but the cross is used for actually disabled options, so there were actually two possible angles for confusion with the way the tristates were. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rando's Combobox and Slider Options were set to decrement when the saved value was bigger than the available options, but if the difference was more than 1, it would still be trying to reference an option out of bounds, thus displaying garbage data in the label, also causing a crash. This changes those two to just set it to the max directly to avoid this.
Also changes the tristate "Off" graphic to be nothing instead of the cross, to avoid confusion thinking that was enabled.
Build Artifacts