Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass for some warning fixes #4501

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Pass for some warning fixes #4501

merged 1 commit into from
Oct 31, 2024

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Oct 31, 2024 •
edited by github-actions bot
Loading

This is a pass over of some warning fixes, including the following:

  • switch statements that didn't have default cases
  • Text widgets that didn't have an explicit format string
  • typedef enums without names (TimeSplit enums also got renamed to distinguish them)
  • uninitialized vars
  • incorrect returns of stack memory addresses
  • Our soh/CMakeLists.txt was in a gitignore for some reason.. (this is why my IDE would never find the file with gitignore exclusions enabled)

Build Artifacts

@Malkierian
Copy link
Contributor

Damn, beat me to it XD

@Archez
Copy link
Contributor Author

Archez commented Oct 31, 2024

Don't worry, I left the most annoying ones still there 😉 (signed/unsigned comparisons and int size comparisons/truncations)

@Malkierian Malkierian merged commit ec1f03e into HarbourMasters:develop Oct 31, 2024
5 checks passed
@Archez Archez deleted the some-warning-fixes branch October 31, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malkierian Malkierian Malkierian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archez @Malkierian