Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for clang compiler #592

Merged
merged 28 commits into from
Jul 10, 2022
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
cc56a5a
hacks to align strings for clang... wow just wow
crowell Jul 4, 2022
6879520
start work to getting built with clang
crowell Jun 20, 2022
1e10fbc
fix issues with struct constructors, all builds, doesn't link still
crowell Jun 20, 2022
0edb646
fix some narrowing issues that clang complains about
crowell Jun 20, 2022
dadd0c7
fix compliation of zapd
crowell Jun 20, 2022
4febaa3
fix null deref in VersionInfo
crowell Jun 20, 2022
56718c4
builds with clang
crowell Jun 20, 2022
bce7ecf
make stringbuilding use StringHelper instead of addition
crowell Jul 5, 2022
54d3c3b
fix linking
crowell Jul 5, 2022
098cb8c
add CLANG SHIP overlay on clang built versions
crowell Jun 29, 2022
211bf79
doesn't need to be volatile
crowell Jul 5, 2022
ffabc6b
mark unknown strings as extern
crowell Jul 5, 2022
e8371b0
rename some stuff
crowell Jul 5, 2022
aaf1632
can't align extern
crowell Jul 5, 2022
2b29dbb
hopefully fix compilation for everythign
crowell Jul 8, 2022
205f815
expandtab
crowell Jul 8, 2022
711aba6
allow setting LD
crowell Jul 8, 2022
b2a663f
Revert "allow setting LD"
crowell Jul 8, 2022
388bf40
-Wno-deprecated-declarations is required for newer versions of clang
crowell Jul 8, 2022
94f9818
Add jenkins support for clang
dcvz Jul 8, 2022
39c67da
Forward CXX flags to stormlib compilation
dcvz Jul 8, 2022
6faedf8
Merge branch 'develop' into devel-clang
crowell Jul 8, 2022
563cd97
Move GCC only flags to check
dcvz Jul 8, 2022
439b319
use exports to set multiarch setup
dcvz Jul 8, 2022
4453b38
Fix Jenkins forever
dcvz Jul 8, 2022
b594621
use make instead of cmake --build
crowell Jul 9, 2022
de879d2
address review coments
crowell Jul 9, 2022
e670d74
update makefile to add WARN on linux+clang
crowell Jul 10, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions libultraship/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ WARN := -Wall -Wextra -Werror \
-Wno-unused-function \
-Wno-parentheses \
-Wno-narrowing \
-Wno-error=stringop-overflow \
crowell marked this conversation as resolved.
Show resolved Hide resolved
-Wno-missing-field-initializers \
-Wno-error=multichar \
-Wno-unused-command-line-argument \
Expand All @@ -27,7 +26,14 @@ WARN := -Wall -Wextra -Werror \
-Wno-deprecated-declarations

CWARN :=
CXXWARN := -Wno-deprecated-enum-enum-conversion -Wno-error=maybe-uninitialized
CXXWARN := -Wno-deprecated-enum-enum-conversion

# Detect if CXX is clang++ or g++, in this order.
crowell marked this conversation as resolved.
Show resolved Hide resolved
COMPILER_VERSION := $(shell $(CXX) --version)
ifneq '' '$(findstring g++,$(COMPILER_VERSION))'
WARN += -Wno-error=stringop-overflow
CXXWARN += -Wno-error=maybe-uninitialized
endif

CXXFLAGS := $(WARN) $(CXXWARN) -std=c++20 -D_GNU_SOURCE -DENABLE_OPENGL -DSPDLOG_ACTIVE_LEVEL=0
CFLAGS := $(WARN) $(CWARN) -std=c99 -D_GNU_SOURCE -DENABLE_OPENGL -DSPDLOG_ACTIVE_LEVEL=0
Expand Down