Minor enhancement: Allow toggling on equipment screen #813
Conversation
Allow player to toggle equipment on/off on the equipment subscreen. For tunics and boots, this will revert them to Kokiri Tunic/Kokiri Boots. For shields, it will un-equip the shield entirely. For swords, only BGS/Giant's Knife is affected, and it will revert to Master Sword.
Set up the cvar/imgui and add a check that we own the Master Sword (in case we're in the Ganon fight)
|
Verified that this feature doesn't cause any obvious issues with the fixes I made in #834 |
I suppose I might say it felt "irresponsible" to allow Link to go swordless so easily via an in-game menu. It is obviously still possible via the save editor or through glitches, but having it in the pause menu made it feel like it's almost "encouraged", in a way. Since there can be some consequences to going swordless that might confuse casual on inexperienced players (issues with some minigames, or the stick-on-b thing that can happen when going back in time without Kokiri Sword), this restriction felt safer to me, even though allowing it would admittedly be more consistent with the other equipment items. I guess an inexperienced player shouldn't have to be aware of possible weird behaviours in order to use all the cool enhancements soh has to offer. My true goal with this feature was really to just allow Link to take his shield off at will (I think Link looks kind of badass with no shield equipped, especially with Biggoron Sword). I decided to expand the feature to the other rows for consistency, though. Edit: With all that said, though - if there are others who feel that it's safe enough to go ahead and allow sword removal here too, then I'd be happy to make the change :) |
|
@Sarge-117 looks like something went very wrong with your rebase? Or maybe you just need to tell GitHub to point to zhora and not Rachael. Either way the diff here is very broken :( |
Yep you're right - it was targeting Rachael by mistake! |
|
I was just asking questions. Your answer makes sense to me. :) |
…#813) * Allow Equipment Toggle Allow player to toggle equipment on/off on the equipment subscreen. For tunics and boots, this will revert them to Kokiri Tunic/Kokiri Boots. For shields, it will un-equip the shield entirely. For swords, only BGS/Giant's Knife is affected, and it will revert to Master Sword. * Set up Cvar and check for MS Set up the cvar/imgui and add a check that we own the Master Sword (in case we're in the Ganon fight)
…#813) * Allow Equipment Toggle Allow player to toggle equipment on/off on the equipment subscreen. For tunics and boots, this will revert them to Kokiri Tunic/Kokiri Boots. For shields, it will un-equip the shield entirely. For swords, only BGS/Giant's Knife is affected, and it will revert to Master Sword. * Set up Cvar and check for MS Set up the cvar/imgui and add a check that we own the Master Sword (in case we're in the Ganon fight)
This small enhancement allows Link to toggle his equipment on the equipment subscreen (by pressing "A" on whatever piece of equipment he currently has on).
Footage: https://cdn.discordapp.com/attachments/936124566764392510/997913791192895508/equipment_toggle.mp4
Specifically:
For swords, he can toggle off the Biggoron Sword (or Giant's Knife) and it will revert him to Master Sword.
For shields, it will allow him to un-equip the shield altogether (this was the original inspiration for this enhancement, because I think Link looks cool without a shield equipped).
For tunics and boots, it will revert him to the Kokiri Tunic/Kokiri Boots.
This does not allow Link to voluntarily go swordless - Kokiri Sword (as child) and Master Sword (as adult) can't be un-equipped. Going swordless can cause some unintended behaviour in some minigames/fishing and possibly other unforeseen areas. Also, in the case of Link having BGS but not having the Master Sword (i.e. Ganon fight), attempting to un-equip your BGS will do nothing.
Thank you to @PurpleHato @jbodner09 for valuable feedback while I was working on this :)