Fix Child Zelda Skip rando setting always on

[jbodner09]

The setting was being written improperly to the spoiler log and also read improperly. It's now being written as a string and then manually set as an int like all other rando settings. Closes #859

[crowell]

it doesn't seem to be "always on". for me it seems somewhat random. maybe something is not initialized?

[crowell]

diff --git a/soh/soh/Enhancements/randomizer/3drando/spoiler_log.cpp b/soh/soh/Enhancements/randomizer/3drando/spoiler_log.cpp
index 5deea40..4f7c2d1 100644
--- a/soh/soh/Enhancements/randomizer/3drando/spoiler_log.cpp
+++ b/soh/soh/Enhancements/randomizer/3drando/spoiler_log.cpp
@@ -42,7 +42,7 @@ static RandomizerHash randomizerHash;
 static SpoilerData spoilerData;
 
 void GenerateHash() {
-    for (size_t i = 0; i < Settings::seed.size(); i++) {
+    for (size_t i = 0; i < Settings::hashIconIndexes.size(); i++) {
         int number = Settings::seed[i] - '0';
         Settings::hashIconIndexes[i] = number;
     }
diff --git a/soh/soh/Enhancements/randomizer/randomizer.cpp b/soh/soh/Enhancements/randomizer/randomizer.cpp
index 09704e8..9091434 100644
--- a/soh/soh/Enhancements/randomizer/randomizer.cpp
+++ b/soh/soh/Enhancements/randomizer/randomizer.cpp
@@ -4756,4 +4756,4 @@ void Rando_Init(void) {
     InitRando();
 }
 
-}
\ No newline at end of file
+}

this diff should work instead.

[jbodner09]

To close the thread: the actual issue was indeed something stomping memory after reading in the cvar. Regressing commit was briaguya-ai@b00c3dd#diff-b38d7696c710c1302dee46cebfa8a7ef693286dacfb3d79c910446d648dc1183

[dcvz]

Looks great! Good job to all, figuring this one out :)

[crowell]

LGTM!

[dcvz]

@jbodner09 sorry one more thing: this would be a great fix to have in Rachael's second release. Could you point this at develop-Rachael?

[briaguya-ai]

we should get this in Rachael

[Kenix3]

We'll also need a PR for zhora.