Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Skulltula Debug functionality to its own checkbox option. #912

Merged
merged 1 commit into from
Jul 24, 2022

Conversation

RevoSucks
Copy link
Contributor

I am preemptively submitting this under a "Hotfix"; the reason is that it's really easy to accidentally corrupt your GS flags when debug is on and a user wont be able to tell that it got desynchronized from the count without a save inspection. (This has already ruined at least one Tokensanity randomizer run)

Copy link
Collaborator

@Kenix3 Kenix3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 point for Gryffindor

Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dcvz dcvz merged commit 01347dc into HarbourMasters:develop-rachael Jul 24, 2022
Kenix3 pushed a commit to Kenix3/Shipwright that referenced this pull request Oct 19, 2022
dcvz pushed a commit to briaguya-ai/Shipwright that referenced this pull request Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants