Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This should fix (all?) 60fps interpolation issues left. #938
This should fix (all?) 60fps interpolation issues left. #938
Changes from all commits
be48f66
0c71488
61e920c
38a9375
73aadd1
432f453
23a05d3
096489b
1a6422f
e354158
f399367
3c8a534
9ca7fba
50d7efc
65ea28c
1a877bd
dd4cfd4
33b151d
07270f2
4819714
412e73b
b18d97e
dbf2381
2d6275b
46c44cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the purpose of these kind of statements to disable interpolation for this object? In any case, use u32 rather than s32 when the number can wrap around since it's UB when an s32 overflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You never resolved this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed the s32 vs u32 thing when going through it this last time, i'll make a cleanup pr for those rn
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first sentence also still applies. Incrementing epoch in the draw function will basically disable interpolation for this object. Don't know if that was intended...