Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check if current is negative #8

Merged
merged 1 commit into from
Oct 31, 2023
Merged

check if current is negative #8

merged 1 commit into from
Oct 31, 2023

Conversation

Mt-is-at-O
Copy link
Contributor

No description provided.

@m12watanabe1a
Copy link
Contributor

Let me check after implementing current value communicator

@m12watanabe1a
Copy link
Contributor

The behavior confirmed with the linked PR.
https://github.com/HarvestX/xvm_ros2/pull/53/files

m12watanabe1a
m12watanabe1a approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@m12watanabe1a m12watanabe1a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m12watanabe1a m12watanabe1a merged commit 386dee4 into humble Oct 31, 2023
2 checks passed
@m12watanabe1a m12watanabe1a deleted the feat/ampere-check branch October 31, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m12watanabe1a m12watanabe1a m12watanabe1a approved these changes

Assignees
No one assigned
Labels
TESTING
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mt-is-at-O @m12watanabe1a