Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub feat #142

Merged
merged 4 commits into from
Jun 10, 2020
Merged

GitHub feat #142

merged 4 commits into from
Jun 10, 2020

Conversation

fuboki10
Copy link
Collaborator

No description provided.

@fuboki10 fuboki10 changed the base branch from master to dev June 10, 2020 02:09
@fuboki10 fuboki10 requested a review from Hassan950 June 10, 2020 02:09
@Hassan950 Hassan950 merged commit 716ae9b into dev Jun 10, 2020
Hassan950 added a commit that referenced this pull request Jun 10, 2020
* Github service added

* Edit gift endpoint to return The current user instead of the gifted user

* Remove unnecessary console log

* Delete unnecessary if statement from chat controller and related unit test

* Add github connect test

* Add username to github

* Refresh token added

* remove func-doc

* ignore functional doc

* GitHub feat (#142)

* Github service added

* Add github connect test

* Add username to github

Co-authored-by: fuboki <fuboki@pop-os.localdomain>

* Add passport controller tests

* Artist feat (#144)

* Update README.md

* Update README.md

* Added get artists by genre feature

* Completed album.controller tests with coverage 100

* Completed tests for artist and tracks controllers with coverage 100%

* Completed track.service tests

* Added tests for album service and small change in the error logging of notifications

* Update README.md

* Completed album service tests

* Completed artist service tests

* Changed the notification remote db url and added more tests for tracks

* removed unnecessary files and small fix in the document of a validation

* Deleted the attachment of requests in case of refusal

* Removed console log left from debugging

Co-authored-by: Hassan Mohamed <42610032+Hassan950@users.noreply.github.com>

* Add reject refresh token

* fix userId in player

Co-authored-by: fuboki <fuboki@pop-os.localdomain>
Co-authored-by: Hassan <hmibrahim1999@gmail.com>
Co-authored-by: mabobakr <42984614+mabobakr@users.noreply.github.com>
Co-authored-by: Hassan Mohamed <42610032+Hassan950@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants