fix: async registerNanoContract call #646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were having intermittent failures on the CI ( example ) due to a NanoContract registration promise being out of sync with the flow of the test suite. This PR ensures they stay in sync by returning the lower level promise instead of just firing it.
This is a similar solution as the one applied on 641.
Acceptance Criteria
registerNanoContract
method should return its underlying operationPromise<void>
Security Checklist