Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async registerNanoContract call #646

Merged
merged 1 commit into from
May 10, 2024
Merged

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented May 8, 2024

We were having intermittent failures on the CI ( example ) due to a NanoContract registration promise being out of sync with the flow of the test suite. This PR ensures they stay in sync by returning the lower level promise instead of just firing it.

This is a similar solution as the one applied on 641.

Acceptance Criteria

  • The registerNanoContract method should return its underlying operation Promise<void>

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the bug Something isn't working label May 8, 2024
@tuliomir tuliomir self-assigned this May 8, 2024
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.48%. Comparing base (2892428) to head (6674f28).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #646       +/-   ##
===========================================
+ Coverage   62.01%   79.48%   +17.47%     
===========================================
  Files          77       77               
  Lines        5826     5826               
  Branches     1210     1223       +13     
===========================================
+ Hits         3613     4631     +1018     
+ Misses       2116     1178      -938     
+ Partials       97       17       -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tuliomir tuliomir merged commit 37050ff into master May 10, 2024
4 checks passed
@tuliomir tuliomir deleted the fix/async-registernc branch May 10, 2024 15:57
This was referenced May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants