Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: string colors to themes #327

Merged
merged 12 commits into from
Sep 26, 2023
Merged

refactor: string colors to themes #327

merged 12 commits into from
Sep 26, 2023

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Sep 13, 2023

While investigating incorrect colors for the application on #326 , all the application existing UI colors were mapped.

This PR refactors all hardcoded colors spread throughout the code into the centralized theme constants. This will allow for easier future development of configurable themes and dark mode.

Acceptance Criteria

  • UI colors should use themes.js constants instead of harcoded strings
ℹ️ Changed colors
Some hardcoded colors were slightly off the mapped ones and were adjusted to the nearest available. These cases were highlighted in the comments below for easier review.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir self-assigned this Sep 13, 2023
This was referenced Sep 18, 2023
@tuliomir tuliomir force-pushed the fix/ios-colors branch 2 times, most recently from 0b163db to 4e5e3d9 Compare September 19, 2023 19:40
Base automatically changed from fix/ios-colors to dev September 20, 2023 17:56
src/components/HathorTextInput.js Outdated Show resolved Hide resolved
src/components/QRCodeReader.js Outdated Show resolved Hide resolved
src/components/ReceiveMyAddress.js Show resolved Hide resolved
src/components/ReceiveMyAddress.js Show resolved Hide resolved
src/components/TokenBox.js Outdated Show resolved Hide resolved
src/screens/WalletConnect/WalletConnectList.js Outdated Show resolved Hide resolved
src/components/NewHathorButton.js Outdated Show resolved Hide resolved
src/screens/WalletConnect/WalletConnectList.js Outdated Show resolved Hide resolved
@tuliomir tuliomir marked this pull request as ready for review September 20, 2023 18:48
src/components/HathorHeader.js Show resolved Hide resolved
src/components/HathorTextInput.js Outdated Show resolved Hide resolved
src/components/HathorTextInput.js Show resolved Hide resolved
src/components/NewHathorButton.js Outdated Show resolved Hide resolved
src/components/QRCodeReader.js Outdated Show resolved Hide resolved
src/components/WalletConnect/ModalButton.js Outdated Show resolved Hide resolved
src/components/WalletConnect/ModalButton.js Outdated Show resolved Hide resolved
src/screens/WalletConnect/WalletConnectList.js Outdated Show resolved Hide resolved
src/screens/WalletConnect/WalletConnectList.js Outdated Show resolved Hide resolved
src/screens/WalletConnect/WalletConnectList.js Outdated Show resolved Hide resolved
@tuliomir tuliomir merged commit 3e301c9 into dev Sep 26, 2023
2 checks passed
@tuliomir tuliomir deleted the refactor/theme-variables branch September 26, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants