-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: string colors to themes #327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 18, 2023
Merged
tuliomir
force-pushed
the
fix/ios-colors
branch
2 times, most recently
from
September 19, 2023 19:40
0b163db
to
4e5e3d9
Compare
tuliomir
force-pushed
the
refactor/theme-variables
branch
from
September 20, 2023 18:23
5c22e24
to
51e701a
Compare
tuliomir
commented
Sep 20, 2023
andreabadesso
approved these changes
Sep 22, 2023
tuliomir
force-pushed
the
refactor/theme-variables
branch
from
September 25, 2023 20:50
7fea4e0
to
a6b16fd
Compare
pedroferreira1
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating incorrect colors for the application on #326 , all the application existing UI colors were mapped.
This PR refactors all hardcoded colors spread throughout the code into the centralized theme constants. This will allow for easier future development of configurable themes and dark mode.
Acceptance Criteria
themes.js
constants instead of harcoded stringsSecurity Checklist