Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow user to close numeric keyboard on iOS #407

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Jan 7, 2024

Summary

As described in #402 , the user is unable to close the numeric keyboard on iOS. On some occasions this causes a bad user experience.

This PR fixes this by adding a press event handler on the screens that exhibit a numeric keyboard.

Acceptance Criteria

Tip

In total, just a few lines had actual text modified. The rest of the modified lines were only due to indentation adjustments.
To better visualize the actual changes I suggest using the "Hide whitespace" feature on GitHub, as it highlights only the words that were changed on this file, and not the indentation adjustments that were necessary:

Ignore Whitespace Diff

Demonstration

Although the video does not exhibit the finger press locations, it's possible to understand the overall interaction: by pressing anywhere on the screen other than the numeric input, the user is able to close the numeric keyboard.

keyboard.closing.by.input.-.iPhone.13.mini.mp4

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the enhancement New feature or request label Jan 7, 2024
@tuliomir tuliomir self-assigned this Jan 7, 2024
@tuliomir tuliomir linked an issue Jan 7, 2024 that may be closed by this pull request
@tuliomir tuliomir requested review from andreabadesso and alexruzenhack and removed request for pedroferreira1 January 7, 2024 12:14
@alexruzenhack
Copy link
Contributor

[non-blocking] Why is this detrimental for the experience? This screen has only one purpose: informe the value.

@tuliomir tuliomir merged commit a9b3936 into dev Jan 9, 2024
2 checks passed
@tuliomir tuliomir deleted the feat/close-keyboard-ios branch January 9, 2024 17:14
@tuliomir
Copy link
Contributor Author

tuliomir commented Jan 9, 2024

@alexruzenhack This was causing issues when, for some reason, the keyboard got in the way of the elements being shown on screen, such as a button.

The main solution to this problem was implemented on #325 , but the option to hide the keyboard was still to be added.

@alexruzenhack alexruzenhack mentioned this pull request Mar 8, 2024
6 tasks
@alexruzenhack alexruzenhack mentioned this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Option to close numeric keyboard on iOS
3 participants