Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: feature toggle using hathor unleash client #421

Merged
merged 4 commits into from
Feb 8, 2024
Merged

refactor: feature toggle using hathor unleash client #421

merged 4 commits into from
Feb 8, 2024

Conversation

andreabadesso
Copy link
Contributor

@andreabadesso andreabadesso commented Jan 29, 2024 •
edited
Loading

Acceptance Criteria

  • We should use the hathor unleash client instead of the official unleash client

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso self-assigned this Jan 29, 2024
@andreabadesso andreabadesso added the enhancement New feature or request label Jan 29, 2024
@andreabadesso andreabadesso force-pushed the refactor/using-hathor-unleash-client branch from f36b7a3 to 8018eb5 Compare February 1, 2024 14:12
@andreabadesso andreabadesso requested review from alexruzenhack and removed request for tuliomir February 1, 2024 14:12
pedroferreira1
pedroferreira1 reviewed Feb 6, 2024
View reviewed changes
src/sagas/featureToggle.js Show resolved Hide resolved
src/sagas/featureToggle.js Show resolved Hide resolved
src/sagas/featureToggle.js Show resolved Hide resolved
@andreabadesso andreabadesso changed the base branch from dev to master February 6, 2024 16:53
@andreabadesso andreabadesso merged commit a8336f9 into master Feb 8, 2024
@andreabadesso andreabadesso deleted the refactor/using-hathor-unleash-client branch February 8, 2024 15:34
This was referenced Mar 6, 2024
Merged
Merged
This was referenced May 9, 2024
Merged
Closed
alexruzenhack pushed a commit that referenced this pull request May 15, 2024
@andreabadesso @alexruzenhack
refactor: feature toggle using hathor unleash client (#421)
a3cae97 
* refactor: feature toggle using hathor unleash client

* feat: handling feature updates

* refactor: using FetchTogglesStatus enum

* chore: added @hathor/unleash-client as a dependency
alexruzenhack pushed a commit that referenced this pull request May 15, 2024
@andreabadesso @alexruzenhack
refactor: feature toggle using hathor unleash client
8827c2a 
* refactor: feature toggle using hathor unleash client (#421)

* feat: handling feature updates

* refactor: using FetchTogglesStatus enum

* chore: added @hathor/unleash-client as a dependency
alexruzenhack pushed a commit that referenced this pull request May 15, 2024
@andreabadesso @alexruzenhack
refactor: feature toggle using hathor unleash client (#421)
3201fd4 
* feat: handling feature updates

* refactor: using FetchTogglesStatus enum

* chore: added @hathor/unleash-client as a dependency
This was referenced May 15, 2024
Closed
Closed
alexruzenhack pushed a commit that referenced this pull request May 15, 2024
@andreabadesso @alexruzenhack
refactor: feature toggle using hathor unleash client (#421)
efc7ec3 
* refactor: feature toggle using hathor unleash client

* feat: handling feature updates

* refactor: using FetchTogglesStatus enum

* chore: added @hathor/unleash-client as a dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@alexruzenhack alexruzenhack alexruzenhack approved these changes

Assignees

@andreabadesso andreabadesso

Labels
enhancement New feature or request
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreabadesso @pedroferreira1 @alexruzenhack