Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useWalletService by forcefully disabling it when wallet service URL is empty #470

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Apr 22, 2024

Acceptance Criteria

  • It should fix wallet-service usage when it should not be used: when a user empty wallet service URL

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

QA Report: https://github.com/HathorNetwork/internal-issues/issues/282
Release: https://github.com/HathorNetwork/internal-issues/issues/249

src/sagas/wallet.js Outdated Show resolved Hide resolved
src/sagas/wallet.js Outdated Show resolved Hide resolved
src/sagas/wallet.js Show resolved Hide resolved
@alexruzenhack alexruzenhack merged commit c49fcb6 into release-candidate Apr 23, 2024
2 checks passed
@alexruzenhack alexruzenhack deleted the fix/use-wallet-service branch April 23, 2024 14:27
@alexruzenhack alexruzenhack mentioned this pull request May 9, 2024
alexruzenhack added a commit that referenced this pull request May 15, 2024
…URL is empty (#470)

refactor: clean tx history and metadata first on wallet start
alexruzenhack added a commit that referenced this pull request May 15, 2024
…URL is empty (#470)

refactor: clean tx history and metadata first on wallet start
@alexruzenhack alexruzenhack mentioned this pull request Aug 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants