fix: allows push notification settings only when using mainnet network #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedroferreira1
approved these changes
May 1, 2024
| state.pushNotification.available | ||
| // On iOS a simulator can't register a device token on APNS | ||
| && state.pushNotification.deviceRegistered | ||
| // TODO: We should drop this condition when we add support other networks |
There was a problem hiding this comment.
Do we have an issue to discuss this?
There was a problem hiding this comment.
This one: https://github.com/HathorNetwork/internal-issues/issues/285
We can keep it open until we find a definite solution. What do you think?
There was a problem hiding this comment.
Here is is a PR to track this TODO: https://github.com/HathorNetwork/internal-issues/issues/288
alexruzenhack
force-pushed
the
fix/push-notification-not-in-mainnet
branch
from
fe1bac6
to
3b30fd6
Compare
andreabadesso
approved these changes
May 2, 2024
Merged
pedroferreira1
pushed a commit
that referenced
this pull request
May 17, 2024
andreabadesso
pushed a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Security Checklist