Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add firstBlock to TxHistory model #476

Merged
merged 2 commits into from
May 23, 2024
Merged

feat: add firstBlock to TxHistory model #476

merged 2 commits into from
May 23, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented May 3, 2024 •
edited
Loading

Acceptance Criteria

  • It should add firstBlock property to TxHistory model
  • Add TransactionStatusLabel to TxDetailsModal

Tx History

Tx Details Modal

Note

It depends on:

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack self-assigned this May 3, 2024
@alexruzenhack alexruzenhack force-pushed the feat/add-first-block branch 2 times, most recently from 00dd63f to f785063 Compare May 3, 2024 16:10
Base automatically changed from feat/nano-contract-tx-history to master May 3, 2024 21:47
@alexruzenhack alexruzenhack requested review from tuliomir and removed request for andreabadesso May 3, 2024 22:02
@pedroferreira1
Copy link
Member

It's missing the screenshot with this new label

tuliomir
tuliomir requested changes May 6, 2024
View reviewed changes
src/models.js Show resolved Hide resolved
@alexruzenhack alexruzenhack merged commit d391fe1 into master May 23, 2024
2 checks passed
@alexruzenhack alexruzenhack deleted the feat/add-first-block branch May 23, 2024 13:31
andreabadesso pushed a commit that referenced this pull request Jun 24, 2024
@alexruzenhack @andreabadesso
feat: add firstBlock to TxHistory model (#476)
9bf99f6 
* feat: add firstBlock and TransactionStatusLabel

* fix: status label and status badge
@alexruzenhack alexruzenhack mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuliomir tuliomir tuliomir approved these changes

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

Assignees

@alexruzenhack alexruzenhack

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexruzenhack @pedroferreira1 @tuliomir