Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: call super method on write #492

Merged
merged 1 commit into from
May 28, 2024
Merged

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented May 28, 2024

Acceptance Criteria

  • We need to call the store's super methods on write operations to avoid errors due to inconsistent storage state.

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer requested a review from alexruzenhack May 28, 2024 15:03
@r4mmer r4mmer self-assigned this May 28, 2024
@r4mmer r4mmer requested a review from pedroferreira1 as a code owner May 28, 2024 15:03
@r4mmer r4mmer merged commit b3cb6a4 into master May 28, 2024
2 checks passed
@r4mmer r4mmer deleted the chore/store-call-super-on-write branch May 28, 2024 19:46
andreabadesso pushed a commit that referenced this pull request Jun 24, 2024
@tuliomir tuliomir mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants