fix: cleaning of tokens and nano-contract registered after reload #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
approved these changes
Jul 4, 2024
pedroferreira1
approved these changes
Jul 5, 2024
| @@ -1229,6 +1229,7 @@ export const onReloadWalletRequested = (state) => ({ | |||
| tokensHistory: initialState.tokensHistory, | |||
| tokensBalance: initialState.tokensBalance, | |||
| loadHistoryStatus: initialState.loadHistoryStatus, | |||
| nanoContract: initialState.nanoContract, | |||
There was a problem hiding this comment.
I think we should improve this docstring. I thought this reload was for any wallet reload, e.g. when the wallet loses internet connection. But this is only after you connect to a new network settings, right? I think this should be explicit in the docstring
andreabadesso
pushed a commit
that referenced
this pull request
Jul 18, 2024
* fix: cleaning of tokens and nano-contract registered after reload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Changing network settings after register nano-contract
When we change the network settings, all registered tokens and nano-contracts are cleaned from storage, therefore the redux state should also resumes to its initial state.
fix-nano-contract-cleaning-after-network-change.mp4
Security Checklist