-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: nano-contract history pagination and list order #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
requested changes
Jul 31, 2024
andreabadesso
requested changes
Jul 31, 2024
andreabadesso
requested changes
Aug 7, 2024
This was referenced Aug 12, 2024
I will open a KTLO for this. See issue #527. |
andreabadesso
requested changes
Aug 13, 2024
pedroferreira1
approved these changes
Aug 17, 2024
- remove delay from saga - default isAddressMine or isMine to false in case user is using wallet service
eb68e50
to
548e23d
Compare
andreabadesso
approved these changes
Aug 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Loading newer transactions
fix-nc-tx-details-loading-logic.mp4
Loading older transactions
nc-load-more-older-txs.mp4
The video above shows a list of transactions initialized with the newest transaction only. When the button 'Load More' is pressed a list of older transactions is loaded. The button 'Load More' didn't show after load because the list has reached its end.
Related issues:
Security Checklist