Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nano-contract history pagination and list order #512

Merged
merged 13 commits into from
Aug 22, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Jul 22, 2024

Acceptance Criteria

  • It should fix nano contract transaction loading for newer transactions
  • Add 'Load More' in the footer of transactions list, which triggers the request for older transactions when pressed
    • Hides the 'Load More' button when the last transaction of the list is the 'initialize'

Loading newer transactions

fix-nc-tx-details-loading-logic.mp4

Loading older transactions

nc-load-more-older-txs.mp4

The video above shows a list of transactions initialized with the newest transaction only. When the button 'Load More' is pressed a list of older transactions is loaded. The button 'Load More' didn't show after load because the list has reached its end.


Related issues:


Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack
Copy link
Contributor Author

alexruzenhack commented Aug 12, 2024

I missed this in the add component PR, but can you rename this component? It doesn't make sense to have a NewHathorButton, how is it different from the HathorButton? Can we merge both?
-- Comment by @andreabadesso on #515, which is now incorporated here.

I will open a KTLO for this.

See issue #527.

@alexruzenhack alexruzenhack merged commit 9103a9e into master Aug 22, 2024
2 checks passed
@alexruzenhack alexruzenhack deleted the fix/nc-tx-loading branch August 22, 2024 16:04
@tuliomir tuliomir mentioned this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants