Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace network identification logic by the lib method #534

Merged
merged 2 commits into from
Aug 22, 2024
Merged

refactor: replace network identification logic by the lib method #534

merged 2 commits into from
Aug 22, 2024

Conversation

alexruzenhack
Copy link
Contributor

@alexruzenhack alexruzenhack commented Aug 15, 2024 •
edited
Loading

Acceptance Criteria

  • Replace the network logic on sagas/networkSettings by the lib method getNetworkFromFullNodeNetwork
  • Update the lib version to v1.9.0

Closes: #521

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack self-assigned this Aug 15, 2024
andreabadesso
andreabadesso requested changes Aug 16, 2024
View reviewed changes
Copy link
Contributor

@andreabadesso andreabadesso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget package.json?

@alexruzenhack
Copy link
Contributor Author

Did you forget package.json?

Indeed. Added now.

@alexruzenhack alexruzenhack merged commit 3eab776 into master Aug 22, 2024
2 checks passed
@alexruzenhack alexruzenhack deleted the feat/check-network-with-lib branch August 22, 2024 16:00
@alexruzenhack alexruzenhack mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@alexruzenhack alexruzenhack

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use a lib method to check the network of a fullnode
3 participants
@alexruzenhack @pedroferreira1 @andreabadesso