Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade actions to a version that use node20 (LTS) #535

Merged
merged 2 commits into from
Aug 23, 2024
Merged

chore: upgrade actions to a version that use node20 (LTS) #535

merged 2 commits into from
Aug 23, 2024

Conversation

r4mmer
Copy link
Member

@r4mmer r4mmer commented Aug 21, 2024

Acceptance Criteria

  • upgrade actions to a version that use node20 (LTS)

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@r4mmer r4mmer requested a review from tuliomir August 21, 2024 03:37
@r4mmer r4mmer self-assigned this Aug 21, 2024
andreabadesso
andreabadesso reviewed Aug 21, 2024
View reviewed changes
.github/workflows/main.yml Outdated
@@ -20,9 +20,9 @@ jobs:
matrix:
node-version: [14.x, 16.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node-version: [14.x, 16.x]
node-version: [18.x, 20.x]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we still use NodeJS 18 in the matrix? Our other repositories are using only version 20.

@r4mmer r4mmer merged commit 6ba53d9 into master Aug 23, 2024
1 check passed
@alexruzenhack alexruzenhack mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

@tuliomir tuliomir Awaiting requested review from tuliomir

Assignees

@r4mmer r4mmer

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@r4mmer @tuliomir @pedroferreira1 @andreabadesso