feat: parse argument value by custom type #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexruzenhack
force-pushed
the
feat/nc-add-arg-type
branch
from
22b81f0
to
0ebc917
Compare
Comment on lines
184
to
185
| // XXX: We may want to extend to show the token symbol of | ||
| // registered tokens. |
There was a problem hiding this comment.
I think we should do it. What we can do is to show: tokenUid (tokenSymbol) and the token symbol only if the token is registered, or ir the default token.
What do you think?
There was a problem hiding this comment.
I have added it at: 3d5f6f6
alexruzenhack
force-pushed
the
feat/nc-add-arg-type
branch
from
a4d0169
to
d81d87b
Compare
src/components/WalletConnect/NanoContract/NanoContractMethodArgs.js
Outdated
Show resolved
Hide resolved
src/components/WalletConnect/NanoContract/NanoContractMethodArgs.js
Outdated
Show resolved
Hide resolved
| @@ -129,6 +144,60 @@ export const NanoContractMethodArgs = ({ blueprintId, method, ncArgs }) => { | |||
| ) | |||
| }; | |||
|
|
|||
| /** | |||
| * Component resposible to render the appropriate format for the value | |||
There was a problem hiding this comment.
Suggested change
| * Component resposible to render the appropriate format for the value | |
| * Component responsible to render the appropriate format for the value |
| * | ||
| * Remarks | ||
| * The values received in here when derived from 'byte' type like | ||
| * 'TxOutputScript', 'TokenUid' and 'VertexId' are already in its |
There was a problem hiding this comment.
Suggested change
| * 'TxOutputScript', 'TokenUid' and 'VertexId' are already in its | |
| * 'TxOutputScript', 'TokenUid' and 'VertexId' are already in their |
| * taking in consideration the type. | ||
| * | ||
| * Remarks | ||
| * The values received in here when derived from 'byte' type like |
There was a problem hiding this comment.
Suggested change
| * The values received in here when derived from 'byte' type like | |
| * The values received here when derived from 'byte' type like |
| * hexadecimal format. | ||
| * | ||
| * Values of type 'Address', which also derives from 'byte' are | ||
| * in its base58 format. |
There was a problem hiding this comment.
Suggested change
| * in its base58 format. | |
| * in base58 format. |
Comment on lines
159
to
160
| * Values of type 'SignedData[Result]' arrives here using its data | ||
| * part already. |
There was a problem hiding this comment.
What does this mean?
There was a problem hiding this comment.
I mean, it is already in presentation format.
src/utils.js
Outdated
| const script = hathorLib.bufferUtils.hexToBuffer(scriptData); | ||
| return hathorLib.scriptsUtils.parseScript(script, network); | ||
| } catch { | ||
| // Avoid to throw exception when we can't parse the script no matter the reason |
There was a problem hiding this comment.
Suggested change
| // Avoid to throw exception when we can't parse the script no matter the reason | |
| // Avoid throwing exception when we can't parse the script no matter the reason |
| return hathorLib.scriptsUtils.parseScript(script, network); | ||
| } catch { | ||
| // Avoid to throw exception when we can't parse the script no matter the reason | ||
| return null; |
pedroferreira1
approved these changes
Aug 27, 2024
andreabadesso
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
The arguments component parsed by custom type
Security Checklist