refactor: replace nano contract state call for history call #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
requested changes
Aug 27, 2024
locale/pt-br/texts.po
Outdated
| @@ -57,7 +57,7 @@ msgid "[Last] dddd [•] HH:mm" | |||
| msgstr "[Última] dddd [•] HH:mm" | |||
|
|
|||
| #. See https://momentjs.com/docs/#/displaying/calendar-time/ | |||
| #: src/models.js:107 src/utils.js:426 | |||
| #: src/models.js:107 src/utils.js:427 | |||
There was a problem hiding this comment.
Why this line changed in src/utils?
There was a problem hiding this comment.
I ran an update, probably it was lacking an update.
locale/texts.pot
Outdated
| @@ -48,7 +48,7 @@ msgid "[Last] dddd [•] HH:mm" | |||
| msgstr "" | |||
|
|
|||
| #: src/models.js:107 | |||
| #: src/utils.js:426 | |||
| #: src/utils.js:427 | |||
There was a problem hiding this comment.
Why this changed? You didn't change src/utils
There was a problem hiding this comment.
I ran an update, probably it was lacking an update.
src/sagas/nanoContract.js
Outdated
| @@ -45,7 +46,8 @@ export const failureMessage = { | |||
| walletNotReadyError: t`Wallet is not ready yet to register a Nano Contract.`, | |||
| addressNotMine: t`The informed address does not belong to the wallet.`, | |||
| nanoContractStateNotFound: t`Nano Contract not found.`, | |||
| nanoContractStateFailure: t`Error while trying to get Nano Contract state.`, | |||
| nanoContractFailure: t`Error while trying register Nano Contract.`, | |||
There was a problem hiding this comment.
Suggested change
| nanoContractFailure: t`Error while trying register Nano Contract.`, | |
| nanoContractFailure: t`Error while trying to register Nano Contract.`, |
There was a problem hiding this comment.
Fixed: 003a3f8
pedroferreira1
approved these changes
Aug 27, 2024
andreabadesso
approved these changes
Aug 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
This is important because the "/state" endpoint is not consistent as it can return "not found" while the new nano contract was not confirmed by a block.
Closes: #510
Security Checklist