feat: add safe effect helper #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexruzenhack
requested review from
tuliomir and
andreabadesso
and removed request for
pedroferreira1
tuliomir
approved these changes
Sep 6, 2024
src/sagas/helpers.js
Outdated
| */ | ||
| export function safeEffect(effect, onError) { | ||
| // eslint-disable-next-line func-names | ||
| return function* (payload) { |
There was a problem hiding this comment.
question(non-blocking): Why not name this function? Wouldn't it help in an eventual debugging session?
There was a problem hiding this comment.
I'm giving it a name _safeEffect: 611e63f. Thank you!
src/sagas/nanoContract.js
Outdated
| */ | ||
| function* registerNanoContractOnError(error) { | ||
| log.error('Unexpected error while registering Nano Contract.', error); | ||
| yield put(nanoContractRegisterFailure(failureMessage.blueprintInfoFailure)); |
There was a problem hiding this comment.
question: Why use the blueprintInfo failure when the error was on a registration event?
There was a problem hiding this comment.
Fixed: b405bbe
| takeEvery(types.NANOCONTRACT_REGISTER_REQUEST, registerNanoContract), | ||
| takeEvery( | ||
| types.NANOCONTRACT_REGISTER_REQUEST, | ||
| safeEffect(registerNanoContract, registerNanoContractOnError) |
There was a problem hiding this comment.
⭐ Nice solution! For the future, I'm thinking of a way to make it more generic, and not require two handler functions for each effect.
There was a problem hiding this comment.
It would be awesome!
alexruzenhack
force-pushed
the
feat/add-safe-effect-utils
branch
from
2478b95
to
611e63f
Compare
tuliomir
approved these changes
Sep 10, 2024
andreabadesso
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Issue: #550
Note
This PR can be cherry-picked to refactor/default-network branch.
Security Checklist