Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bumps Android target SDK to 34 #562

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

tuliomir
Copy link
Contributor

@tuliomir tuliomir commented Sep 11, 2024

Acceptance Criteria

  • The application build process should target Android SDK 34

Notes about build environment

The application build was run on Ubuntu 22, with the following devices working successfully

  • Emulator running Android 13
  • Motorola G52 physical device running Android 13
  • Emulator running Android 15

To ensure the build was being executed in an environment as reproducible as possible, the following cache clearing script was used:

#!/bin/bash

# Clear global android cache of NDK's
rm -rf /home/my_user/Android/Sdk/ndk/*

# Clear all builds within the project
rm -rf /home/my_user/mobile-wallet/android/.gradle
rm -rf /home/my_user/mobile-wallet/android/build
rm -rf /home/my_user/mobile-wallet/android/app/build

# Clear all leaking gradle processes
cd ~/mobile-wallet/android
./gradlew --stop
pkill -9 -f gradle
cd ~/

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@tuliomir tuliomir added the dependencies Pull requests that update a dependency file label Sep 11, 2024
@tuliomir tuliomir self-assigned this Sep 11, 2024
@tuliomir tuliomir marked this pull request as ready for review September 11, 2024 03:29
@tuliomir tuliomir requested review from andreabadesso and removed request for pedroferreira1 September 11, 2024 03:29
@tuliomir tuliomir changed the base branch from master to hathorplay-base-release September 11, 2024 15:06
@andreabadesso andreabadesso merged commit 3565387 into hathorplay-base-release Sep 11, 2024
@andreabadesso andreabadesso deleted the feat/android-target-34 branch September 11, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants