feat: make requestUnregisteredTokens concurrent #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexruzenhack
requested review from
andreabadesso and
r4mmer
and removed request for
pedroferreira1
alexruzenhack
changed the title
- add action UNREGISTEREDTOKENS_FAILURE - add action UNREGISTEREDTOKENS_END - rename action UREGISTEREDTOKENS_UPDATE to UREGISTEREDTOKENS_SUCCESS - improve documentation
alexruzenhack
force-pushed
the
feat/add-concurrency-to-calls
branch
from
0d09a93
to
6514956
Compare
r4mmer
reviewed
Sep 17, 2024
andreabadesso
requested changes
Sep 18, 2024
andreabadesso
approved these changes
Sep 24, 2024
r4mmer
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The user needs the data as quick as possible in a new nano contract request. To achieve this requirement we can make the http request concurrent, however we should respect the rate-limit rules set in public node endpoints.
Acceptance Criteria
Future possibility
We can implement a client object that implements a more sophisticated limit-rate strategy that adapts to back pressure from server. This control is interesting to pursuit in order to better rationalize the resources at app disposal and at the same time helps the server to heal in case of spike usage.
Note
It closes #531.
Warning
To work properly it depends on the fix on promise leak, see HathorNetwork/hathor-wallet-lib#772.
Security Checklist