fix: empty caller after define first address #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It should inform the caller was not set and ask user to select one when:
- the registered nano contract doesn't have an address, which should not happen anymore
- the first address request fails, which can happen when the effect is requested by a initilize call
or by a not registered nano contract
andreabadesso
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
initializecall onNanoContractExecInfocomponentInitialize working
hathorplay-initialize-working.mp4
Not registered nano bet working
hathorplay-not-registered-nano-bet.mp4
Caller empty or first address request failed
The following screenshot simulates the caller empty, it is very unlikely to happen now.
Security Checklist