Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change nc address by renaming the param to newAddress #571

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: change nc address by renaming the param to newAddress #571

merged 1 commit into from
Sep 26, 2024

Conversation

alexruzenhack
Copy link
Contributor

Motivation

The change address action for registered Nano Contract is brocken.

Acceptance Criteria

  • Fix effect to change address for registered Nano Contract by using the correct param name newAddress

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@alexruzenhack alexruzenhack self-assigned this Sep 18, 2024
@alexruzenhack alexruzenhack requested review from tuliomir and removed request for andreabadesso September 19, 2024 16:37
@alexruzenhack alexruzenhack requested review from andreabadesso and removed request for tuliomir September 24, 2024 16:33
@alexruzenhack alexruzenhack merged commit 2a972d2 into master Sep 26, 2024
1 check passed
@alexruzenhack alexruzenhack deleted the fix/change-nc-address branch September 26, 2024 16:36
@alexruzenhack alexruzenhack mentioned this pull request Oct 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@andreabadesso andreabadesso andreabadesso approved these changes

Assignees

@alexruzenhack alexruzenhack

Labels
None yet
Projects
Hathor Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexruzenhack @pedroferreira1 @andreabadesso