feat: reown on nano contracts #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
force-pushed
the
feat/reown-on-nano-contracts
branch
from
9115c8e to
e1bb3c7
Compare
pedroferreira1
approved these changes
Nov 7, 2024
tuliomir
approved these changes
Nov 7, 2024
| @@ -130,12 +130,15 @@ function* isReownEnabled() { | |||
| } | |||
|
|
|||
| function* init() { | |||
| const walletStartState = yield select((state) => state.walletStartState); | |||
|
|
|||
| if (walletStartState !== WALLET_STATUS.READY) { | |||
There was a problem hiding this comment.
chore: We can remove WALLET_STATUS from the imports (line 75) since we removed the only places where it was being read.
src/sagas/wallet.js
Outdated
| @@ -254,10 +254,14 @@ export function* startWallet(action) { | |||
| yield put(setUniqueDeviceId(uniqueDeviceId)); | |||
|
|
|||
| try { | |||
| yield call(wallet.start.bind(wallet), { | |||
| // XXX: This comes as undefined when the facede is the wallet-service. | |||
There was a problem hiding this comment.
Suggested change
| // XXX: This comes as undefined when the facede is the wallet-service. | |
| // XXX: This comes as undefined when the facade is the wallet-service. |
andreabadesso
force-pushed
the
feat/reown-on-nano-contracts
branch
from
25ba554 to
12d067c
Compare
andreabadesso
force-pushed
the
feat/reown-on-nano-contracts
branch
from
12d067c to
bf83166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance Criteria
Security Checklist