Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: button font size #622

Merged
merged 2 commits into from
Nov 9, 2024
Merged

fix: button font size #622

merged 2 commits into from
Nov 9, 2024

Conversation

andreabadesso
Copy link
Contributor

@andreabadesso andreabadesso commented Nov 9, 2024 •
edited
Loading

Before the fix:

  • Seed cutting off text
  • Invisible reset wallet on android

After the fix:

  • Seed not cutting off text
  • Reset wallet visible:

Acceptance Criteria

  • Fonts were being cut off on some devices

Security Checklist

  • Make sure you do not include new dependencies in the project unless strictly necessary and do not include dev-dependencies as production ones. More dependencies increase the possibility of one of them being hijacked and affecting us.

@andreabadesso andreabadesso merged commit 6cc8af7 into release-candidate Nov 9, 2024
1 check passed
@andreabadesso andreabadesso deleted the fix/button-font-size branch November 9, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroferreira1 pedroferreira1 pedroferreira1 approved these changes

@msbrogli msbrogli msbrogli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreabadesso @msbrogli @pedroferreira1