test: Try to fix test for windows.

HavenDV · Dec 8, 2023 · 2e16710 · 2e16710
1 parent bc692c1
commit 2e16710
Show file tree

Hide file tree

Showing 3 changed files with 44 additions and 8 deletions.
diff --git a/src/libs/H.Pipes.AccessControl/PipeServerExtensions.cs b/src/libs/H.Pipes.AccessControl/PipeServerExtensions.cs
@@ -28,7 +28,15 @@ public static void SetPipeSecurity<T>(this IPipeServer<T> server, PipeSecurity p
         server = server ?? throw new ArgumentNullException(nameof(server));
         pipeSecurity = pipeSecurity ?? throw new ArgumentNullException(nameof(pipeSecurity));
 
-        server.CreatePipeStreamFunc = pipeName => NamedPipeServerStreamConstructors.New(pipeName, PipeDirection.InOut, 1, PipeTransmissionMode.Byte, PipeOptions.Asynchronous | PipeOptions.WriteThrough, 0, 0, pipeSecurity);
+        server.CreatePipeStreamFunc = pipeName => NamedPipeServerStreamConstructors.New(
+            pipeName: pipeName,
+            direction: PipeDirection.InOut,
+            maxNumberOfServerInstances: 1,
+            transmissionMode: PipeTransmissionMode.Byte,
+            options: PipeOptions.Asynchronous | PipeOptions.WriteThrough,
+            inBufferSize: 0,
+            outBufferSize: 0,
+            pipeSecurity: pipeSecurity);
     }
 
     /// <summary>

diff --git a/src/libs/H.Pipes/PipeServer.cs b/src/libs/H.Pipes/PipeServer.cs
@@ -177,7 +177,8 @@ await handshakeWrapper.WriteAsync(Encoding.UTF8.GetBytes(connectionPipeName), to
                     }
 
                     // Wait for the client to connect to the data pipe
-                    var connectionStream = (CreatePipeStreamForConnectionFunc ?? CreatePipeStreamFunc)?.Invoke(connectionPipeName) ?? PipeServerFactory.Create(connectionPipeName);
+                    var connectionStream = (CreatePipeStreamForConnectionFunc ?? CreatePipeStreamFunc)?
+                        .Invoke(connectionPipeName) ?? PipeServerFactory.Create(connectionPipeName);
 
                     PipeStreamInitializeAction?.Invoke(connectionStream);
 

diff --git a/src/tests/H.Pipes.Tests/Tests.cs b/src/tests/H.Pipes.Tests/Tests.cs
@@ -2,6 +2,8 @@
 using System.Collections.Concurrent;
 using System.IO.Pipes;
 using System.Net;
+using System.Security.AccessControl;
+using System.Security.Principal;
 
 namespace H.Pipes.Tests;
 
@@ -141,12 +143,37 @@ public async Task WriteOnlyServer()
             Console.WriteLine($"PipeName: {pipeName}");
 
             await using var server = new PipeServer<byte[]>(pipeName);
-            server.CreatePipeStreamFunc = static pipeName => new NamedPipeServerStream(
-                pipeName,
-                PipeDirection.Out,
-                1,
-                PipeTransmissionMode.Byte,
-                PipeOptions.Asynchronous | PipeOptions.WriteThrough);
+            if (OperatingSystem.IsWindows())
+            {
+                var pipeSecurity = new PipeSecurity();
+                pipeSecurity.AddAccessRule(new PipeAccessRule(
+                    new SecurityIdentifier(WellKnownSidType.WorldSid, null),
+                    PipeAccessRights.ReadWrite,
+                    AccessControlType.Allow));                
+
+#pragma warning disable CA1416
+                server.CreatePipeStreamFunc = name => NamedPipeServerStreamAcl.Create(
+                    pipeName: name,
+                    direction: PipeDirection.Out,
+                    maxNumberOfServerInstances: 1,
+                    transmissionMode: PipeTransmissionMode.Byte,
+                    options: PipeOptions.Asynchronous | PipeOptions.WriteThrough,
+                    inBufferSize: 0,
+                    outBufferSize: 0,
+                    pipeSecurity: pipeSecurity);
+#pragma warning restore CA1416
+            }
+            else
+            {
+                server.CreatePipeStreamFunc = static pipeName => new NamedPipeServerStream(
+                    pipeName: pipeName,
+                    direction: PipeDirection.Out,
+                    maxNumberOfServerInstances: 1,
+                    transmissionMode: PipeTransmissionMode.Byte,
+                    options: PipeOptions.Asynchronous | PipeOptions.WriteThrough,
+                    inBufferSize: 0,
+                    outBufferSize: 0);
+            }
 
             server.ClientConnected += async (_, args) =>
             {