[cpp] Support extern enums #10830
Merged
[cpp] Support extern enums #10830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to add a test case for this? |
|
Should be, I'll look into it. |
Aidan63
force-pushed
the
cpp-extern-enums
branch
from
f009acc to
f58bea1
Compare
Aidan63
force-pushed
the
cpp-extern-enums
branch
from
f58bea1 to
2abfaa1
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you tried to create an extern enum on cpp it would generate invalid cpp as it tried to import header files for that extern as if it were generated by the haxe compiler instead of using the
@:includemeta attached to the extern.