Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] fix previous job cancellation for pull requests from forks #10901

Merged
merged 4 commits into from
Dec 22, 2022
Merged

[ci] fix previous job cancellation for pull requests from forks #10901

merged 4 commits into from
Dec 22, 2022

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Dec 22, 2022

@kLabz
Copy link
Contributor Author

kLabz commented Dec 22, 2022

Eh, as said there astropy/astropy#11330 :

Note: Not sure how to prove it to you since this workflow_run does not take effect until merged. I did test it on my fork and proved it for myself, but the log doesn't say what canceled a given job, just that the job is canceled, so... you'll just have to trust me.

@kLabz kLabz marked this pull request as ready for review December 22, 2022 14:38
@Simn
Copy link
Member

Simn commented Dec 22, 2022

Well, for science!

@Simn Simn merged commit 36bddcc into HaxeFoundation:development Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kLabz @Simn