-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacroApi cleanup for Haxe 5 #11433
base: development
Are you sure you want to change the base?
MacroApi cleanup for Haxe 5 #11433
Conversation
This should no longer be necessary. I'm adding the relevant tests to make sure.
Since adding optional fields always incurs a marginal risk for breaking user code, might I use this opportunity to request also adding the positions of other names currently not exposed?
I see that some of these are already encoded in an unspecified FWIW I think in the types from |
I'll have to check all this again, I thought this |
# Conflicts: # src/typing/macroContext.ml
* [macro] Don't choke on namePos for reification pattern matching * [tests] Add test for 11670 * Do it like in #11433
* [macro] Don't choke on namePos for reification pattern matching * [tests] Add test for 11670 * Do it like in #11433
* [macro] Don't choke on namePos for reification pattern matching * [tests] Add test for 11670 * Do it like in #11433
# Conflicts: # src/typing/matcher/exprToPattern.ml
@yuxiaomao Could you check this one too? Thanks! |
It didn't break anything as far as I see, however in one of the projects I'm getting a warning many times (60+) at the same location in hxbit (https://github.com/HeapsIO/hxbit/blob/010d65702548fb2547cc7f6113910fcef4f68731/hxbit/Macros.hx#L561 at
Which is not the case with current development branch (with development, there is no warning at all). I'm not familiar with macro nor hxbit, and with |
This could come from something that used to have |
Still some TODOs.
Closes #11431