Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generator-specific context #11471

Merged
merged 16 commits into from
Nov 22, 2024
Merged

Add generator-specific context #11471

merged 16 commits into from
Nov 22, 2024

Conversation

Simn
Copy link
Member

@Simn Simn commented Jan 8, 2024

This PR adds a lightweight version of Common.context which holds all the data generators need. For now it's only implemented for genjvm, but should be relatively easy to add to other generators.

The main goal is to make my dependency dot graphs look nicer.

Before:

gctx before

After:

gctx after

@Simn
Copy link
Member Author

Simn commented Jan 8, 2024

I have also already "ported" our second best generator genhl, which was easy enough.

Before:

genhl before

After:

genhl after

Unlike in some other areas, smaller is better.

@skial skial mentioned this pull request Jan 9, 2024
1 task
# Conflicts:
#	src/core/stringHelper.ml
#	src/generators/genhl.ml
#	src/generators/genjvm.ml
# Conflicts:
#	src/compiler/generate.ml
#	src/generators/genhl.ml
#	src/generators/genjvm.ml
@Simn
Copy link
Member Author

Simn commented Nov 22, 2024

JS fails with some DCE problems, which isn't a great sign for this endeavor... I can't tell what changed here data-wise but it's likely related to the feature feature.

Edit: never mind, the has_feature I originally ported was simply outdated.

@Simn
Copy link
Member Author

Simn commented Nov 22, 2024

This should be ready now, although macos-14 is still failing for some reason.

I've taken the opportunity to remove some generator-specific deprecation warnings because Haxe 5 is the right time to do that. Other than that we should have cleaner internal dependencies now.

@Aidan63 This might cause you some conflicts with your gencpp work, but it hopefully won't be that bad!

@Simn Simn merged commit e253d37 into development Nov 22, 2024
79 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant