-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generator-specific context #11471
Conversation
# Conflicts: # src/core/stringHelper.ml # src/generators/genhl.ml # src/generators/genjvm.ml
# Conflicts: # src/compiler/generate.ml # src/generators/genhl.ml # src/generators/genjvm.ml
argh
JS fails with some DCE problems, which isn't a great sign for this endeavor... I can't tell what changed here data-wise but it's likely related to the feature feature. Edit: never mind, the |
This should be ready now, although macos-14 is still failing for some reason. I've taken the opportunity to remove some generator-specific deprecation warnings because Haxe 5 is the right time to do that. Other than that we should have cleaner internal dependencies now. @Aidan63 This might cause you some conflicts with your gencpp work, but it hopefully won't be that bad! |
This PR adds a lightweight version of
Common.context
which holds all the data generators need. For now it's only implemented for genjvm, but should be relatively easy to add to other generators.The main goal is to make my dependency dot graphs look nicer.
Before:
After: