Add support for null coalescing (?? & ??=)
#131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simn
reviewed
Jun 27, 2024
hscript/Parser.hx
Outdated
| mk(ETernary( | ||
| mk(EBinop("==", mk(EIdent(tmp),pmin(e1),pmax(e1)), mk(EIdent("null"),pmin(e1),pmax(e1)))), | ||
| e2, | ||
| e1 |
There was a problem hiding this comment.
Shouldn't this be tmp to avoid code duplication?
There was a problem hiding this comment.
This also means that a relevant test is missing.
There was a problem hiding this comment.
i just made one and after the change runs successfully, but maybe pushing it would be a lot of code just for it that now works great. I had to make a new class with a integer variable with a getter function that increases everytime you access it
|
should be good now |
|
Is there any new about this? |
|
btw i just added support for |
gamerbross
changed the title
?? & ??=)
|
You should do "??" + "=" since the c++ compiler converts ??= to a # |
The cpp tagert will break if you don't make this change .___. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing to explain :)