Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@:remove extern private must be valid #202

Closed
boozook opened this issue Apr 4, 2015 · 6 comments
Closed

@:remove extern private must be valid #202

boozook opened this issue Apr 4, 2015 · 6 comments
Labels

Comments

@boozook
Copy link

boozook commented Apr 4, 2015

Pls add @:remove extern private into bnf.
Example gist: (https://gist.github.com/puffnfresh/5314836#file-valueclass-hx-L6-L7) (not my)
screen shot 2015-04-04 at 4 02 59

@as3boyan
Copy link
Contributor

as3boyan commented Apr 4, 2015

Seems like private is not expected.
Update: it's fine, the thing is that we don't support extern interfaces yet

@as3boyan
Copy link
Contributor

as3boyan commented Apr 4, 2015

@Simn maybe just add a bit info on use private keywords on classes, I found example here http://old.haxe.org/ref/oop

@as3boyan
Copy link
Contributor

as3boyan commented Apr 4, 2015

It seems like here, we are not expecting other structures than class

externClassDeclaration ::= macroClassList? externOrPrivate* 'class' componentName genericParam? inheritList? '{' externClassDeclarationBody '}'
{pin=4 mixin="com.intellij.plugins.haxe.lang.psi.impl.AbstractHaxePsiClass" implements="com.intellij.plugins.haxe.lang.psi.HaxeClass"}

@Simn
Copy link
Member

Simn commented Apr 4, 2015

Not sure what you want to know. You can have any number of metadata and then optionally private or (not xor) extern in any order. That's true for both class and interface.

@as3boyan
Copy link
Contributor

as3boyan commented Apr 4, 2015

I added interface to extern classes, and I thought that maybe I was missing something else. I think now plugin works in a same way as you mentioned. Thanks for info.

as3boyan added a commit that referenced this issue Apr 6, 2015
@EBatTiVo EBatTiVo added the bug label Apr 21, 2015
@EBatTiVo
Copy link
Contributor

We've got a merged fix. Closing. @fzzr- Please test and re-open if the bug recurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants