Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findUsages import statement occurrence filter not working as expected #426

Closed
sganapavarapu1 opened this issue Feb 22, 2016 · 5 comments
Closed

Comments

@sganapavarapu1
Copy link
Contributor

FindUsages output window has filters on its left menu as shortcut icons. These filters, when working (e.g. for Java code), allow you to hide import statement occurrences or interface occurrences etc. Various filters are available for various purposes.

Haxe plugin's findUsage output doesn't seem to be filterable.
At least, I couldn't filter "import " statement occurrences. I didn't test all others, but another filter icon was also not effective.

See attached screen capture

idea

@eliasku
Copy link
Contributor

eliasku commented Mar 1, 2016

@sganapavarapu1 It was not implemented before

PR #446
importfiltering

sganapavarapu1 added a commit that referenced this issue Mar 1, 2016
…Rule

[FindUsages] Import filtering (Issue #426)
@EBatTiVo
Copy link
Contributor

EBatTiVo commented Mar 1, 2016

@sganapavarapu1 Please close this after you've verified it.

@EBatTiVo
Copy link
Contributor

EBatTiVo commented Mar 1, 2016

@sganapavarapu1 Strike that. I'll just close it pre-emptively. Re-open if it recurs.

@EBatTiVo EBatTiVo closed this as completed Mar 1, 2016
@eliasku
Copy link
Contributor

eliasku commented Mar 2, 2016

@sganapavarapu1 @EBatTiVo
This ticket is created about general filters support. We've fixed only import filter support. Grouping is not implemented, read/write is also works weird way. But I suggest to close this one and create more descriptive and specific issues for the remaining support (grouping and read/write filters) to make tasks more clear for contributors.

@sganapavarapu1
Copy link
Contributor Author

@eliasku
I agree. Though my intent was to open the ticket only for import filter (as I thought that's small enough to achieve), I ended up making title cover broader scope. Yes, making smaller tickets encourages contributions, easier to review/merge and manage overall in remote working conditions.

@sganapavarapu1 sganapavarapu1 changed the title findUsages output view filters not working as expected findUsages import statement occurrence filter not working as expected Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants