Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename references when renaming class https://github.com/TiVo/intellij-haxe/issues/222 https://github.com/TiVo/intellij-haxe/issues/11 #224

Merged
merged 1 commit into from
Apr 10, 2015

Conversation

as3boyan
Copy link
Contributor

Rename references when renaming class
#222
#11

return this;
}

private void bindToClass(PsiClass element) {
handleElementRename(element.getName());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handleElementRename method replaces Identifier with new one

so basically if class has full qualified name like com.foo.Test,
Test will be passed to rename function, handleElementRename made in such way that it will rename last Identifier only, so

if reference looks like com.foo.Test, handleElementRename would simply replace last, third Identifier Test with new Identifier with new name.

So it should work fine I hope.
Java implementation may perform more checks https://github.com/JetBrains/intellij-community/blob/master/java/java-psi-impl/src/com/intellij/psi/impl/source/PsiJavaCodeReferenceElementImpl.java#L545

as3boyan added a commit that referenced this pull request Apr 10, 2015
Rename references when renaming class #222 #11
@as3boyan as3boyan merged commit 510fe07 into master Apr 10, 2015
@as3boyan as3boyan deleted the FixRenameTestCase branch April 10, 2015 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants