Unknown semantics #320
Merged
Unknown semantics #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created SpecificTypeReferenceHolder in order to be able to mutate results (Unknown), keeping SpecificTypeReference immutable and extendable (normal types + functional types). Handled a new case: var a; a = 10; a = 'test'; // error here! a = 20;
- Renamed SpecificTypeReferenceHolder to ResultHolder - Added canMutate to ResultHolder so you can detect trying to change a inline variable
Added some global fixers
… so types can be resolved
| return HaxeTypeResolver.getFieldOrMethodReturnType((AbstractHaxeNamedComponent)this.getPsi(), resolver); | ||
| } | ||
|
|
||
| public SpecificFunctionReference getFunctionType(@Nullable HaxeGenericResolver resolver) { |
There was a problem hiding this comment.
Small nit. Please keep functions with identical names next to each other. It just makes them easier to scan for. In this case, getReturnType(resolver) should have come before getFunctionType(), and both getFunctionType() methods should be next to one another.
There was a problem hiding this comment.
I have to review some classes including this one. I have evolved them and there are some inconsistencies out there including wrong naming and some strange stuff.
I'm taking note on this one.
|
@soywiz OK. I'm done reviewing for now. Awaiting your response. |
|
Ok. I have read all your comments and suggestions. Tomorrow with some more time I will make a commit with fixes. |
EBatTiVo
added a commit
that referenced
this pull request
Jun 29, 2015
Semantic Annotator: Handle types that are initially "Unknown."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes "Unknown" semantics #317