Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Keras to 2.4.0 to be compatible with Python 3.8 #86

Merged
merged 4 commits into from
Oct 9, 2020

Conversation

HiromuHota
Copy link
Contributor

@HiromuHota HiromuHota commented Oct 9, 2020

Description of the problems or issues

Is your pull request related to a problem? Please describe.

In order for pdftotree to support Python 3.8, its dependency on Keras needs to be 2.4.0 or later.

Does your pull request fix any issue.

Related to #85

Description of the proposed changes

Upgrade Keras to 2.4.0 to be compatible with Python 3.8

Test plan

pdftotree depends on Keras for the vision model.
I'll add a test to make sure the vision model runs without an error and returns results in expected format, but not check the results itself.

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the CHANGELOG.md accordingly.

@codecov-io
Copy link

codecov-io commented Oct 9, 2020

Codecov Report

Merging #86 into master will increase coverage by 0.16%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   65.62%   65.79%   +0.16%     
==========================================
  Files          21       22       +1     
  Lines        2508     2523      +15     
==========================================
+ Hits         1646     1660      +14     
- Misses        862      863       +1     
Flag Coverage Δ
#unittests 65.79% <100.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
pdftotree/visual/visual_utils.py 96.92% <100.00%> (+0.09%) ⬆️
tests/test_basic.py 95.08% <100.00%> (+0.08%) ⬆️
tests/test_table_detection.py 100.00% <100.00%> (ø)
pdftotree/utils/pdf/render.py 0.00% <0.00%> (ø)
pdftotree/utils/pdf/vector_utils.py 66.66% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbe6a1a...0e37972. Read the comment docs.

@HiromuHota HiromuHota marked this pull request as ready for review October 9, 2020 19:48
@HiromuHota HiromuHota requested a review from lukehsiao October 9, 2020 19:49
Copy link
Contributor

@lukehsiao lukehsiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HiromuHota HiromuHota merged commit f631efc into HazyResearch:master Oct 9, 2020
@HiromuHota HiromuHota deleted the upgrade/keras branch October 9, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants