Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework iteration to avoid overflow #68

Merged
merged 8 commits into from
Oct 24, 2017
Merged

Commits on Oct 18, 2017

  1. Failing test to show that iter_recorded stops too soon

    Marshall Pierce authored and marshallpierce committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    5e02609 View commit details
    Browse the repository at this point in the history
  2. Pull quantile stuff out of data_access because the quantile stuff is …

    …porky enough to stand on its own and data_access is a port of a Java test file anyway.
    marshallpierce committed Oct 18, 2017
    Configuration menu
    Copy the full SHA
    95436cb View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2017

  1. Rework iteration logic.

    - `LinearIterator` no longer aborts one step too early in the final bucket.
    - `PickyIterator` now returns metadata when it picks. This allows `IterationValue` to provide better data about the current iteration progress without introducing a separate stage in the `PickyIterator` lifecycle to query about what was just picked.
    - count since last iteration is now reset every iteration, making it less prone to overflow.
    - end-of-histogram is detected by comparing with max nonzero index, not total count, which avoids overflow.
    marshallpierce committed Oct 19, 2017
    Configuration menu
    Copy the full SHA
    421791d View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2017

  1. Configuration menu
    Copy the full SHA
    85eadf7 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2017

  1. Improve quantile iteration logic, and document its quirkiness.

    - Supply count at current index to `pick()` since we already have that available
    - Quantile iterator won't get stuck asymptotically chasing quantile 1.0_f64
    - More tests
    marshallpierce committed Oct 24, 2017
    Configuration menu
    Copy the full SHA
    beec46f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e250d1b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dd2fd6c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b9e12c9 View commit details
    Browse the repository at this point in the history