-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework iteration to avoid overflow #68
Merged
Merged
Commits on Oct 18, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 5e02609 - Browse repository at this point
Copy the full SHA 5e02609View commit details -
Pull quantile stuff out of data_access because the quantile stuff is …
…porky enough to stand on its own and data_access is a port of a Java test file anyway.
Configuration menu - View commit details
-
Copy full SHA for 95436cb - Browse repository at this point
Copy the full SHA 95436cbView commit details
Commits on Oct 19, 2017
-
- `LinearIterator` no longer aborts one step too early in the final bucket. - `PickyIterator` now returns metadata when it picks. This allows `IterationValue` to provide better data about the current iteration progress without introducing a separate stage in the `PickyIterator` lifecycle to query about what was just picked. - count since last iteration is now reset every iteration, making it less prone to overflow. - end-of-histogram is detected by comparing with max nonzero index, not total count, which avoids overflow.
Configuration menu - View commit details
-
Copy full SHA for 421791d - Browse repository at this point
Copy the full SHA 421791dView commit details
Commits on Oct 23, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 85eadf7 - Browse repository at this point
Copy the full SHA 85eadf7View commit details
Commits on Oct 24, 2017
-
Improve quantile iteration logic, and document its quirkiness.
- Supply count at current index to `pick()` since we already have that available - Quantile iterator won't get stuck asymptotically chasing quantile 1.0_f64 - More tests
Configuration menu - View commit details
-
Copy full SHA for beec46f - Browse repository at this point
Copy the full SHA beec46fView commit details -
Configuration menu - View commit details
-
Copy full SHA for e250d1b - Browse repository at this point
Copy the full SHA e250d1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd2fd6c - Browse repository at this point
Copy the full SHA dd2fd6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b9e12c9 - Browse repository at this point
Copy the full SHA b9e12c9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.