Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all): demo fix in ie11 #610

Merged
merged 2 commits into from
Nov 14, 2018

Conversation

benjanderson
Copy link
Contributor

Fixes issues with loading the demo in IE11 by adding a hard dependency on an older version of punycode. According to this comment, they updated their code to only support ES6 angular/angular-cli#9508 (comment) and I tested out just adding the older version to our node_modules directory and it worked ;)

Would someone with a windows machine validate this works as well?

Closes #491

@corykon
Copy link
Collaborator

corykon commented Nov 14, 2018

@benjanderson here's what I'm seeing:
In IE11: Everything renders, but there are several small bugs. I can submit a new issue for all of these.

In Edge: Accordion & Form Field don't render at all. Navbar and Picklist sometimes show up, but on a second visit to that tab seemed not to render. Not seeing anything in the console. :/

@corykon
Copy link
Collaborator

corykon commented Nov 14, 2018

Logged IE 11 bugs here: #614

@benjanderson
Copy link
Contributor Author

@corykon Wow, thanks for the thorough feedback. My goal was just to get IE to load and it looks like you successfully did that. I think we are on a good course to making the library more robust with IE and edge by logging #614 and #200 .

That said, I think we can merge these changes as a first step. Could you please approve it?

@benjanderson benjanderson merged commit 51c1295 into HealthCatalyst:dev Nov 14, 2018
@benjanderson benjanderson deleted the fix-ie11-demo branch November 14, 2018 21:44
@benjanderson
Copy link
Contributor Author

🎉 This PR is included in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants