Remove ShardedJedis in order to focus core functionality (3.x) #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove ShardedJedis and relevant classes, methods ** also remove unit tests / benchmark tests * Rearrange Pipeline to reflect removing ShardedJedis … ** We don't need to separate single key and multi keys operation *** cause JedisCluster can't use Pipeline by nature ** Rename interfaces to respect naming convention ** and so on...
|
I'll handle the build error later. Seems like SSL test issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin PR: redis#875
https://groups.google.com/d/msg/jedis_redis/7ZJPFp_qTY0/mIZ9qZ8ZgdkJ
We're decided to stop supporting ShardedJedis starting from 3.x. (with leaving it to 2.x)
I removed ShardedJedis with relevant codes and try to clean codes to make Jedis clearer.
At first, many classes are related to ShardedJedis including utilities, so we can get rid of it.
And we can simplify Pipeline and relevant interfaces because there's no need to split operations which one is single key and other one is multi keys.
In addition, I've modified some interfaces name cause to have consistent naming convention.
redis#630 also removes ShardedJedis, but it removes only ShardedJedis and relevant codes, not modifying interfaces, and Pipeline.