Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad error handling when input file cannot be found #1

Closed
eschen42 opened this issue Aug 26, 2018 · 1 comment
Closed

bad error handling when input file cannot be found #1

eschen42 opened this issue Aug 26, 2018 · 1 comment
Assignees

Comments

@eschen42
Copy link
Collaborator

When an input file cannot be found, I get the following message:

Error { message: promise already under evaluation: recursive default argument reference or earlier problems? , call: read_data_frame(xcms_data_in, sprintf(\"%s input\", xcms_data_type)) }

I need a test to execute this path and to fix the issue, which may stem from setting the default value for an argument to a nested function to the value of a variable in the enclosing scope; e.g., this gives the promise error:

foo <- "hello"
bar <- function(foo = foo) { print(foo) }
bar()

but this does not:

foo <- "hello"
bar <- function(fee = foo) { print(fee) }
bar()
@eschen42
Copy link
Collaborator Author

eschen42 commented Sep 1, 2018

fixed by commit 2279142

@eschen42 eschen42 closed this as completed Sep 1, 2018
@eschen42 eschen42 self-assigned this Sep 1, 2018
eschen42 added a commit to HegemanLab/w4mcorcov_galaxy_wrapper that referenced this issue Sep 1, 2018
eschen42 added a commit to HegemanLab/w4mclstrpeakpics that referenced this issue Sep 1, 2018
eschen42 added a commit to HegemanLab/w4mkmeans_galaxy_wrapper that referenced this issue Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant