Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify lower limit to number of cross-validation segments #14

Closed
eschen42 opened this issue Oct 12, 2020 · 1 comment
Closed

Specify lower limit to number of cross-validation segments #14

eschen42 opened this issue Oct 12, 2020 · 1 comment
Assignees

Comments

@eschen42
Copy link
Contributor

eschen42 commented Oct 12, 2020

Currently, a high number of cross-validation segments causes some comparisons to be suppressed. For example, with three replicates of three treatments, the current minimum of 7 suppresses pair-wise contrasts because one cannot use 7 cross-validation segments with six samples.

Add a parameter min_crossval_i (with a default value of 7) to specify this, and use its value in lieu of 7 in lines 603, 677, 756, and 809 of w4mcorcov_calc.R, all of which currently are

, x_crossval_i  = min(7, length(chosen_samples))
@eschen42 eschen42 changed the title Specify upper limit to number of cross-validation segments Specify lower limit to number of cross-validation segments Nov 16, 2020
eschen42 added a commit that referenced this issue Nov 17, 2020
@eschen42
Copy link
Contributor Author

eschen42 commented Nov 18, 2020

Fixed in commit 5fd9687 for release v0.98.18

@eschen42 eschen42 self-assigned this Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant