Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only contrast chosen factor levels #8

Closed
eschen42 opened this issue Sep 4, 2018 · 1 comment
Closed

Only contrast chosen factor levels #8

eschen42 opened this issue Sep 4, 2018 · 1 comment
Assignees
@eschen42
Labels
bug

Comments

@eschen42
Copy link
Contributor

eschen42 commented Sep 4, 2018

When release https://github.com/HegemanLab/w4mcorcov_galaxy_wrapper/releases/tag/v0.98.14 compares one factor level to "other" it compares it to all other factor levels, not to other chosen factor levels. I don't imagine that most people would expect that; as the author, I know that I expect "other" to be the other chosen factor levels.
@eschen42 eschen42 added the bug label Sep 4, 2018
@eschen42 eschen42 self-assigned this Sep 4, 2018
eschen42 added a commit that referenced this issue Sep 5, 2018
@eschen42
fixes for #8 - regression tests are still needed
c13f430
eschen42 added a commit that referenced this issue Sep 5, 2018
@eschen42
added planemo and scripted tests for issue #8
15c61fa
@eschen42
Copy link
Contributor Author

eschen42 commented Sep 6, 2018

Fixed by commit c13f430
Tests are in commit 15c61fa

@eschen42 eschen42 closed this as completed Sep 6, 2018
@eschen42 eschen42 changed the title Only compare chosen factor levels Only contrast chosen factor levels Sep 6, 2018
@eschen42 eschen42 mentioned this issue Sep 6, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eschen42 eschen42

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eschen42