fix user pagination and page setting #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies user pagination and time filtering functionality in the Helicone web application.
- Added time filter parameter to
useUsershook in/web/services/hooks/users.tsxbut count endpoint doesn't use combined filter - Switched from prop-based to URL query parameter state management in
/web/components/templates/users/usersPageV2.tsx - Inconsistency between default sort direction ('asc') and fallback ('desc') in user page sorting
- Updated page size options and defaults for user table pagination
- Added
useQueryParamhook for URL parameter synchronization
2 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+70
to
+73
| const [sortDirection, setSortDirection] = useQueryParam( | ||
| "sortDirection", | ||
| "asc" | ||
| ); |
There was a problem hiding this comment.
logic: Default sortDirection is 'asc' but fallback on line 89 uses 'desc'. This inconsistency could cause unexpected sorting behavior.
Comment on lines
93
to
102
| const { users, count, from, isLoading, to, refetch } = useUsers( | ||
| currentPage, | ||
| pageSize, | ||
| parseInt(currentPage, 10), | ||
| parseInt(pageSize, 10), | ||
| sortLeaf, | ||
| filterUITreeToFilterNode( | ||
| userTableFilters.sort((a, b) => a.label.localeCompare(b.label)), | ||
| debouncedAdvancedFilters | ||
| ) | ||
| // timeFilter | ||
| ); |
There was a problem hiding this comment.
style: refetch is imported but never used after removing the refetch calls from page change handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.