Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Enable and configure visibility_required fixer #69

Merged
merged 2 commits into from
Mar 3, 2020
Merged

Enhancement: Enable and configure visibility_required fixer #69

merged 2 commits into from
Mar 3, 2020

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Mar 3, 2020 •
edited
Loading

This PR

  • enables and configures the visibility_required fixer
  • runs php-cs-fixer fix

Follows #52.
Spotted in #68.

@localheinz localheinz marked this pull request as ready for review March 3, 2020 15:46
@glaubinix
Copy link
Collaborator

Looks good! Ready to merge if you could also rebase this one.

@localheinz
Copy link
Contributor Author

@glaubinix

Rebased!

@glaubinix glaubinix merged commit 0d84cc0 into HelloGrayson:master Mar 3, 2020
@glaubinix
Copy link
Collaborator

Thank you!

@localheinz localheinz deleted the feature/visibility-required branch March 3, 2020 16:19
@localheinz
Copy link
Contributor Author

Thank you, @glaubinix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@localheinz @glaubinix