Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to Bevy 0.14 #4

Closed
wants to merge 4 commits into from
Closed

Conversation

a-panda-miner
Copy link

@a-panda-miner a-panda-miner commented Nov 5, 2024

What works so far:
Both chessboard examples
Unicode terrain

What doesn't work:
All Cartesian3D examples

Possible cause:
Out of Bounds error in internal_generator.rs:660

Note: Everything is only made for Cartesian2D and Cartesian3D, the generator isn't generalized for any Grid< C >
Note2: I needed to add a backend so winit would compile in bevy 0.14, don't know if there is a workaround for libraries

As is you can (probably) use this branch for Cartesian2D generations without issues

EDIT: Found one source of the Cartesian3D not working, total_size() function worked differently in the ghx_grid 0.2 compared to ghx_grid 0.4, don't know if it is a bug or intentional. Now pillars example work but canyon still doesn't

Found more total_size() calls to replace.
Ran cargo fmt
@a-panda-miner
Copy link
Author

Now the only example that doesn't run is the Canyon one

@a-panda-miner
Copy link
Author

a-panda-miner commented Nov 6, 2024

I believe I've found the issue:
https://docs.rs/ghx_grid/0.2.0/src/ghx_grid/grid.rs.html#317-322
became this:
https://docs.rs/ghx_grid/0.4.0/src/ghx_grid/cartesian/grid.rs.html#348-350

but as stated earlier, the self.total_size() is different, that's why there is an out of bounds

@Henauxg
Copy link
Owner

Henauxg commented Nov 7, 2024

I am in the process or reviewing this and #2 .

Good catch on the total_size error, it was a copy of the specific 2d implementation, I have release fixes in ghx_grid.

In order to keep things a bit more separated I will first integrate the changes due to the version upgrade of ghx_grid (generic grid trait) before updating to bevy 0.14 (and 0.15 rc).

@Henauxg
Copy link
Owner

Henauxg commented Nov 7, 2024

Updated to 0.14 on main

@Henauxg Henauxg closed this Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants